Fix HUD CPU usage: measure /proc/stat load instead of clock-frequency#614
Draft
Xnick417x wants to merge 6 commits into
Draft
Fix HUD CPU usage: measure /proc/stat load instead of clock-frequency#614Xnick417x wants to merge 6 commits into
Xnick417x wants to merge 6 commits into
Conversation
… ratio Compute CPU% from /proc/stat busy vs idle jiffie deltas (on-screen HUD and Task Manager pane, aggregate and per-core) instead of scaling_cur_freq/max which does not reflect actual utilization. Add Mali GPU load fallbacks (/sys/kernel/gpu/gpu_busy, /proc/mtk_mali/utilization).
Poll the second CPU sample after 500ms during warm-up (then settle to 1s) and force a redraw when the first real value lands, so the on-screen HUD stops showing CPU N/A within about half a second instead of a full second. Reset the previous sample when stats start so re-showing the HUD no longer reports a delta spanning the hidden period.
On devices where the app cannot read /proc/stat, the delta sampler returned no data and the HUD showed CPU N/A. Try /proc/stat first (accurate) and fall back to the clock-frequency estimate so a value always shows, on both the on-screen HUD and the Task Manager pane.
The kgsl gpubusy counter reads busy=0 total=0 at idle; dividing by total==0 fell through to the read-failure path and showed N/A. Return 0 for that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute CPU% from /proc/stat busy vs idle jiffie deltas (on-screen HUD and Task Manager pane, aggregate and per-core) instead of scaling_cur_freq/max which does not reflect actual utilization. Add Mali GPU load fallbacks (/sys/kernel/gpu/gpu_busy, /proc/mtk_mali/utilization).